Remove both default arguments to the constructor of ANSI_X931_RNG.

If the second argument was NULL, it would default to a new Randpool.
But this introduces an annoying dependency: really it is the caller who
is relying on Randpool. Make this explicit by passing a new Randpool
pointer to the constructor in Library_State.

This will break all callers using ANSI_X931_RNG's constructors with
default arguments. To regain the previous behavior, change:
  ANSI_X931_RNG rng;
  ANSI_X931_RNG rng("/*cipher name*/");
to
  ANSI_X931_RNG rng(/*cipher name, default was AES-256 */, new Randpool);

You are free to pass another PRNG object if you like.

This make require inclusion of <botan/randpool.h>

1 files changed, 1 insertions, 1 deletions

diff --git a/include/x931_rng.h b/include/x931_rng.h
index 3cfa52b6a..8bb8cc2ac 100644
--- a/include/x931_rng.h
+++ b/include/x931_rng.h
@@ -21,7 +21,7 @@ class BOTAN_DLL ANSI_X931_RNG : public RandomNumberGenerator
       void clear() throw();
       std::string name() const;
 
-      ANSI_X931_RNG(const std::string& = "", RandomNumberGenerator* = 0);
+      ANSI_X931_RNG(const std::string&, RandomNumberGenerator*);
       ~ANSI_X931_RNG();
    private:
       void add_randomness(const byte[], u32bit);