Remove final on TLS policy objects (GH #1292)

2 files changed, 11 insertions, 4 deletions

diff --git a/news.rst b/news.rst
index 3f103942e..e79f3e444 100644
--- a/news.rst
+++ b/news.rst
@@ -78,6 +78,13 @@ Version 2.4.0, Not Yet Released
   could be used was by manually constructing a ``CTR_BE`` object and
   setting the second parameter to something in the range of 1 to 3.
 
+* In 2.3.0, final annotations were added to many classes including the TLS
+  policies (like ``Strict_Policy`` and ``BSI_TR_02102_2``). However it is
+  reasonable and useful for an application to derive from one of these policies, so
+  as to create an application specific policy that is based on a library-provided
+  policy, but with a few tweaks. So the final annotations have been removed on
+  these classes. (GH #1292)
+
 * Add an OID for RIPEMD-160
 
 * Fixes for CMake build (GH #1251)
diff --git a/src/lib/tls/tls_policy.h b/src/lib/tls/tls_policy.h
index 499ae91ba..db2cbb3bb 100644
--- a/src/lib/tls/tls_policy.h
+++ b/src/lib/tls/tls_policy.h
@@ -326,7 +326,7 @@ class BOTAN_PUBLIC_API(2,0) Policy
 /**
 * NSA Suite B 128-bit security level (RFC 6460)
 */
-class BOTAN_PUBLIC_API(2,0) NSA_Suite_B_128 final : public Policy
+class BOTAN_PUBLIC_API(2,0) NSA_Suite_B_128 : public Policy
    {
    public:
       std::vector<std::string> allowed_ciphers() const override
@@ -362,7 +362,7 @@ class BOTAN_PUBLIC_API(2,0) NSA_Suite_B_128 final : public Policy
 /**
 * BSI TR-02102-2 Policy
 */
-class BOTAN_PUBLIC_API(2,0) BSI_TR_02102_2 final : public Policy
+class BOTAN_PUBLIC_API(2,0) BSI_TR_02102_2 : public Policy
    {
    public:
       std::vector<std::string> allowed_ciphers() const override
@@ -423,7 +423,7 @@ class BOTAN_PUBLIC_API(2,0) BSI_TR_02102_2 final : public Policy
 /**
 * Policy for DTLS. We require DTLS v1.2 and an AEAD mode.
 */
-class BOTAN_PUBLIC_API(2,0) Datagram_Policy final : public Policy
+class BOTAN_PUBLIC_API(2,0) Datagram_Policy : public Policy
    {
    public:
       std::vector<std::string> allowed_macs() const override
@@ -443,7 +443,7 @@ class BOTAN_PUBLIC_API(2,0) Datagram_Policy final : public Policy
 * to use if you control both sides of the protocol and don't have to worry
 * about ancient and/or bizarre TLS implementations.
 */
-class BOTAN_PUBLIC_API(2,0) Strict_Policy final : public Policy
+class BOTAN_PUBLIC_API(2,0) Strict_Policy : public Policy
    {
    public:
       std::vector<std::string> allowed_ciphers() const override;