aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJack Lloyd <[email protected]>2019-05-24 18:32:04 -0400
committerJack Lloyd <[email protected]>2019-05-24 18:32:04 -0400
commit5941fd903c6dca738193327940fe04393b756ab5 (patch)
tree7466e6659996e3754096c9a0f7e9fad64a0e40fb
parent7de87541af346350c2305f38241b8549c9a63b9d (diff)
Add reminder comments re enum class
-rw-r--r--src/lib/asn1/asn1_obj.h1
-rw-r--r--src/lib/tls/tls_extensions.h1
-rw-r--r--src/lib/tls/tls_magic.h3
-rw-r--r--src/lib/x509/crl_ent.h1
4 files changed, 6 insertions, 0 deletions
diff --git a/src/lib/asn1/asn1_obj.h b/src/lib/asn1/asn1_obj.h
index e44b30771..41228a2d8 100644
--- a/src/lib/asn1/asn1_obj.h
+++ b/src/lib/asn1/asn1_obj.h
@@ -18,6 +18,7 @@ class DER_Encoder;
/**
* ASN.1 Type and Class Tags
+* This will become an enum class in a future major release
*/
enum ASN1_Tag : uint32_t {
UNIVERSAL = 0x00,
diff --git a/src/lib/tls/tls_extensions.h b/src/lib/tls/tls_extensions.h
index 7dda6aaa0..76d072763 100644
--- a/src/lib/tls/tls_extensions.h
+++ b/src/lib/tls/tls_extensions.h
@@ -28,6 +28,7 @@ class Policy;
class TLS_Data_Reader;
+// This will become an enum class in a future major release
enum Handshake_Extension_Type {
TLSEXT_SERVER_NAME_INDICATION = 0,
TLSEXT_CERT_STATUS_REQUEST = 5,
diff --git a/src/lib/tls/tls_magic.h b/src/lib/tls/tls_magic.h
index f9643f004..48bb34f4a 100644
--- a/src/lib/tls/tls_magic.h
+++ b/src/lib/tls/tls_magic.h
@@ -24,8 +24,10 @@ enum Size_Limits {
MAX_CIPHERTEXT_SIZE = MAX_COMPRESSED_SIZE + 1024,
};
+// This will become an enum class in a future major release
enum Connection_Side { CLIENT = 1, SERVER = 2 };
+// This will become an enum class in a future major release
enum Record_Type {
CHANGE_CIPHER_SPEC = 20,
ALERT = 21,
@@ -35,6 +37,7 @@ enum Record_Type {
NO_RECORD = 256
};
+// This will become an enum class in a future major release
enum Handshake_Type {
HELLO_REQUEST = 0,
CLIENT_HELLO = 1,
diff --git a/src/lib/x509/crl_ent.h b/src/lib/x509/crl_ent.h
index 9c9e86c03..ea64ee21a 100644
--- a/src/lib/x509/crl_ent.h
+++ b/src/lib/x509/crl_ent.h
@@ -18,6 +18,7 @@ struct CRL_Entry_Data;
/**
* X.509v2 CRL Reason Code.
+* This will become an enum class in a future major release
*/
enum CRL_Code : uint32_t {
UNSPECIFIED = 0,