diff options
| author | Jack Lloyd <[email protected]> | 2017-10-09 10:50:45 -0400 |
|---|---|---|
| committer | Jack Lloyd <[email protected]> | 2017-10-09 10:50:45 -0400 |
| commit | c62a6d43ca9bc9481d741cfe3c319210eaf231b8 (patch) | |
| tree | e132882e8d571a11a37fa415781c92c1ef38666a | |
| parent | 03292e638bede9b386f07e02e8bbdefd0fef53dd (diff) | |
Add comments explaining why its ok to rely on deprecated features here.
[ci skip]
| -rw-r--r-- | src/lib/tls/tls_blocking.cpp | 4 | ||||
| -rw-r--r-- | src/lib/tls/tls_channel.cpp | 4 |
2 files changed, 8 insertions, 0 deletions
diff --git a/src/lib/tls/tls_blocking.cpp b/src/lib/tls/tls_blocking.cpp index 75f7154a4..d89c11a2c 100644 --- a/src/lib/tls/tls_blocking.cpp +++ b/src/lib/tls/tls_blocking.cpp @@ -25,6 +25,10 @@ Blocking_Client::Blocking_Client(read_fn reader, const std::vector<std::string>& next) : m_read(reader), m_callbacks(new TLS::Compat_Callbacks( + /* + we are ok using deprecated features here because the whole Blocking_Client class + is also deprecated, so just silence the warning. + */ TLS::Compat_Callbacks::SILENCE_DEPRECATION_WARNING::PLEASE, writer, std::bind(&Blocking_Client::data_cb, this, _1, _2), diff --git a/src/lib/tls/tls_channel.cpp b/src/lib/tls/tls_channel.cpp index 143453ba3..2f8e72228 100644 --- a/src/lib/tls/tls_channel.cpp +++ b/src/lib/tls/tls_channel.cpp @@ -50,6 +50,10 @@ Channel::Channel(output_fn out, size_t io_buf_sz) : m_is_datagram(is_datagram), m_compat_callbacks(new Compat_Callbacks( + /* + this Channel constructor is also deprecated so its ok that it + relies on a deprecated API + */ Compat_Callbacks::SILENCE_DEPRECATION_WARNING::PLEASE, out, app_data_cb, alert_cb, hs_cb, hs_msg_cb)), m_callbacks(*m_compat_callbacks.get()), |