From 46808404eaf53aba1cb754bac733dce43bf4158c Mon Sep 17 00:00:00 2001 From: dynaflash Date: Thu, 9 Feb 2012 21:59:07 +0000 Subject: MacGui: Add ffmpeg (lavc) advanced options text box to the advanced panel. - Fix a couple other traps for x264 opts as well. - Add lavcOption Key to the presets as per the LinGui to maintain preset parity. git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@4443 b64f7644-9d1e-0410-96f1-a4d463321fa5 --- macosx/Controller.m | 48 +- macosx/English.lproj/AdvancedView.xib | 1324 +++++++-------------------------- macosx/HBAdvancedController.h | 5 + macosx/HBAdvancedController.m | 12 +- macosx/HBQueueController.mm | 22 +- 5 files changed, 343 insertions(+), 1068 deletions(-) (limited to 'macosx') diff --git a/macosx/Controller.m b/macosx/Controller.m index 86b949d05..dbecb9018 100644 --- a/macosx/Controller.m +++ b/macosx/Controller.m @@ -2348,6 +2348,8 @@ fWorkingCount = 0; [queueFileJob setObject:[fVidEncoderPopUp titleOfSelectedItem] forKey:@"VideoEncoder"]; /* x264 Option String */ [queueFileJob setObject:[fAdvancedOptions optionsString] forKey:@"x264Option"]; + /* FFMpeg (lavc) Option String */ + [queueFileJob setObject:[fAdvancedOptions optionsStringLavc] forKey:@"lavcOption"]; [queueFileJob setObject:[NSNumber numberWithInt:[[fVidQualityMatrix selectedCell] tag] + 1] forKey:@"VideoQualityType"]; [queueFileJob setObject:[fVidBitrateField stringValue] forKey:@"VideoAvgBitrate"]; @@ -3087,6 +3089,11 @@ fWorkingCount = 0; } + else + { + job->advanced_opts = (char *)calloc(1024, 1); /* Fixme, this just leaks */ + strcpy(job->advanced_opts, [[fAdvancedOptions optionsStringLavc] UTF8String]); + } /* Video settings */ @@ -3583,6 +3590,14 @@ bool one_burned = FALSE; } } + else + { + if ([queueToApply objectForKey:@"lavcOption"]) + { + job->advanced_opts = (char *)calloc(1024, 1); /* Fixme, this just leaks */ + strcpy(job->advanced_opts, [[queueToApply objectForKey:@"lavcOption"] UTF8String]); + } + } /* Picture Size Settings */ @@ -4778,6 +4793,11 @@ the user is using "Custom" settings by determining the sender*/ [fAdvancedOptions setHidden:NO]; [self autoSetM4vExtension: sender]; } + else // we are FFmpeg (lavc) + { + [fAdvancedOptions setHidden:YES]; + } + if (videoEncoder != HB_VCODEC_X264) { @@ -5663,11 +5683,34 @@ return YES; /* Video encoder */ [fVidEncoderPopUp selectItemWithTitle:[chosenPreset objectForKey:@"VideoEncoder"]]; + [self videoEncoderPopUpChanged:nil]; /* We set the advanced opt string here if applicable*/ - [fAdvancedOptions setOptions:[chosenPreset objectForKey:@"x264Option"]]; + if ([[fVidEncoderPopUp selectedItem] tag] == HB_VCODEC_X264) + { + if ([chosenPreset objectForKey:@"x264Option"]) + { + [fAdvancedOptions setOptions:[chosenPreset objectForKey:@"x264Option"]]; + } + else + { + [fAdvancedOptions setOptions:@""]; + } + + } + else // we are ffmpeg encoder + { + if ([chosenPreset objectForKey:@"lavcOption"]) + { + [fAdvancedOptions setLavcOptions:[chosenPreset objectForKey:@"lavcOption"]]; + } + else + { + [fAdvancedOptions setLavcOptions:@""]; + } + } /* Lets run through the following functions to get variables set there */ - [self videoEncoderPopUpChanged:nil]; + //[self videoEncoderPopUpChanged:nil]; /* Set the state of ipod compatible with Mp4iPodCompatible. Only for x264*/ [fDstMp4iPodFileCheck setState:[[chosenPreset objectForKey:@"Mp4iPodCompatible"] intValue]]; [self calculateBitrate:nil]; @@ -6242,6 +6285,7 @@ return YES; [preset setObject:[fVidEncoderPopUp titleOfSelectedItem] forKey:@"VideoEncoder"]; /* x264 Option String */ [preset setObject:[fAdvancedOptions optionsString] forKey:@"x264Option"]; + [preset setObject:[fAdvancedOptions optionsStringLavc] forKey:@"lavcOption"]; /* though there are actually only 0 - 1 types available in the ui we need to map to the old 0 - 2 * set of indexes from when we had 0 == Target , 1 == Abr and 2 == Constant Quality for presets diff --git a/macosx/English.lproj/AdvancedView.xib b/macosx/English.lproj/AdvancedView.xib index 6ce828731..1cc653dbe 100644 --- a/macosx/English.lproj/AdvancedView.xib +++ b/macosx/English.lproj/AdvancedView.xib @@ -2,30 +2,36 @@ 1050 - 10J869 - 732 - 1038.35 - 461.00 + 11C74 + 1938 + 1138.23 + 567.00 com.apple.InterfaceBuilder.CocoaPlugin - 732 + 1938 - + YES - + NSPopUpButton + NSMenuItem + NSMenu + NSTextFieldCell + NSButtonCell + NSButton + NSSlider + NSSliderCell + NSCustomView + NSCustomObject + NSPopUpButtonCell + NSTextField YES com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - - - YES - + PluginDependencyRecalculationVersion + YES @@ -48,6 +54,8 @@ 268 {{298, 275}, {61, 14}} + + YES 68288064 @@ -84,6 +92,8 @@ 268 {{1, 275}, {66, 14}} + + YES 68288064 @@ -100,6 +110,8 @@ 268 {{1, 128}, {91, 14}} + + YES 68288064 @@ -116,6 +128,8 @@ 256 {{124, 151}, {97, 15}} + + YES -2076049856 @@ -196,6 +210,8 @@ 256 {{333, 107}, {116, 16}} + + YES 67239424 @@ -216,6 +232,8 @@ 268 {{454, 105}, {146, 16}} + + YES -2079981824 @@ -238,6 +256,8 @@ 256 {{18, 170}, {102, 16}} + + YES 67239424 @@ -254,6 +274,8 @@ 256 {{122, 172}, {22, 16}} + + YES 67239424 @@ -281,6 +303,8 @@ 256 {{124, 256}, {97, 15}} + + YES -2076049856 @@ -351,6 +375,8 @@ 256 {{26, 254}, {94, 16}} + + YES 67239424 @@ -367,6 +393,8 @@ 256 {{15, 233}, {105, 16}} + + YES 67239424 @@ -383,6 +411,8 @@ 256 {{349, 254}, {100, 16}} + + YES 67239424 @@ -399,6 +429,8 @@ 256 {{124, 235}, {97, 15}} + + YES -2076049856 @@ -469,6 +501,8 @@ 256 {{453, 256}, {149, 15}} + + YES -2076049856 @@ -543,6 +577,8 @@ 256 {{453, 193}, {149, 15}} + + YES -2076049856 @@ -613,6 +649,8 @@ 256 {{720, 233}, {37, 16}} + + YES 67239424 @@ -629,6 +667,8 @@ 256 {{17, 107}, {103, 16}} + + YES 67239424 @@ -645,6 +685,8 @@ 256 {{4, 0}, {882, 34}} + + YES -1805517311 @@ -653,7 +695,7 @@ YES - + 6 System textBackgroundColor @@ -662,7 +704,7 @@ MQA - + 6 System textColor @@ -675,6 +717,8 @@ 256 {{453, 214}, {149, 15}} + + YES -2076049856 @@ -745,6 +789,8 @@ 256 {{314, 212}, {135, 16}} + + YES 67239424 @@ -761,6 +807,8 @@ 256 {{320, 170}, {129, 16}} + + YES 67239424 @@ -777,6 +825,8 @@ 256 {{453, 172}, {149, 15}} + + YES -2076049856 @@ -847,6 +897,8 @@ 256 {{298, 191}, {151, 16}} + + YES 67239424 @@ -863,6 +915,8 @@ 256 {{15, 149}, {105, 16}} + + YES 67239424 @@ -879,6 +933,8 @@ 256 {{304, 86}, {145, 16}} + + YES 67239424 @@ -895,6 +951,8 @@ 256 {{337, 233}, {112, 16}} + + YES 67239424 @@ -911,6 +969,8 @@ 256 {{453, 235}, {149, 15}} + + YES -2076049856 @@ -981,6 +1041,8 @@ 256 {{1, 42}, {221, 17}} + + YES 67239424 @@ -997,6 +1059,8 @@ 256 {{758, 109}, {130, 15}} + + YES -2076049856 @@ -1067,6 +1131,8 @@ 256 {{758, 88}, {130, 15}} + + YES -2076049856 @@ -1137,6 +1203,8 @@ 256 {{695, 107}, {62, 16}} + + YES 67239424 @@ -1153,6 +1221,8 @@ 256 {{122, 109}, {22, 16}} + + YES 67239424 @@ -1174,6 +1244,8 @@ 256 {{758, 235}, {130, 15}} + + YES -2076049856 @@ -1244,6 +1316,8 @@ 256 {{758, 256}, {130, 15}} + + YES -2076049856 @@ -1314,6 +1388,8 @@ 256 {{674, 254}, {83, 16}} + + YES 67239424 @@ -1330,6 +1406,8 @@ 256 {{122, 193}, {22, 16}} + + YES 67239424 @@ -1351,6 +1429,8 @@ 256 {{40, 191}, {80, 16}} + + YES 67239424 @@ -1367,6 +1447,8 @@ 256 {{122, 214}, {22, 16}} + + YES 67239424 @@ -1388,6 +1470,8 @@ 256 {{1, 212}, {119, 16}} + + YES 67239424 @@ -1404,6 +1488,8 @@ 268 {{454, 84}, {146, 16}} + + YES -2079981824 @@ -1426,6 +1512,8 @@ 256 {{347, 65}, {102, 16}} + + YES 67239424 @@ -1442,6 +1530,8 @@ 268 {{454, 63}, {146, 16}} + + YES -2079981824 @@ -1462,32 +1552,58 @@ {906, 290} + + NSView NSResponder - + 256 YES - + 256 - {{20, 206}, {660, 14}} + {{1, 42}, {264, 17}} + + YES - + 67239424 - 138412032 - Small System Font Text - - + 272629760 + Current FFMpeg Advanced Option String: + + + + + 256 + {{4, 0}, {882, 34}} + + + + YES + + -1805517311 + 272760832 + + + + YES + + + + {906, 290} + + + NSView @@ -1849,14 +1965,6 @@ 256 - - - fX264optViewTitleLabel - - - - 257 - fX264optPsyRDLabel @@ -1993,13 +2101,39 @@ 434 + + + X264AdvancedOptionsSet: + + + + 452 + + + + fDisplayLavcOptions + + + + 455 + + + + fDisplayLavcOptionsLabel + + + + 456 + YES 0 - + + YES + @@ -2320,20 +2454,12 @@ YES - + + empty - - 255 - - - YES - - - - 342 @@ -2509,11 +2635,6 @@ - - 381 - - - 7 @@ -3044,65 +3165,70 @@ + + 450 + + + YES + + + + + + 451 + + + + + 453 + + + YES + + + + + + 454 + + + YES YES + -1.IBPluginDependency + -2.IBPluginDependency -3.IBPluginDependency - -3.ImportedFromIB2 10.IBPluginDependency - 10.ImportedFromIB2 11.IBAttributePlaceholdersKey 11.IBPluginDependency - 11.ImportedFromIB2 12.IBAttributePlaceholdersKey 12.IBPluginDependency - 12.ImportedFromIB2 13.IBAttributePlaceholdersKey 13.IBPluginDependency - 13.ImportedFromIB2 14.IBPluginDependency - 14.ImportedFromIB2 15.IBPluginDependency - 15.ImportedFromIB2 16.IBPluginDependency - 16.ImportedFromIB2 17.IBPluginDependency - 17.ImportedFromIB2 18.IBAttributePlaceholdersKey 18.IBPluginDependency - 18.ImportedFromIB2 19.IBPluginDependency - 19.ImportedFromIB2 20.IBPluginDependency - 20.ImportedFromIB2 21.IBPluginDependency - 21.ImportedFromIB2 22.IBPluginDependency - 22.ImportedFromIB2 23.IBAttributePlaceholdersKey 23.IBPluginDependency - 23.ImportedFromIB2 24.IBAttributePlaceholdersKey 24.IBPluginDependency - 24.ImportedFromIB2 - 254.IBEditorWindowLastContentRect 254.IBPluginDependency - 254.ImportedFromIB2 - 254.editorWindowContentRectSynchronizationRect - 255.IBPluginDependency - 255.ImportedFromIB2 30.IBPluginDependency - 30.ImportedFromIB2 32.IBAttributePlaceholdersKey 32.IBPluginDependency - 32.ImportedFromIB2 33.IBPluginDependency - 33.ImportedFromIB2 34.IBPluginDependency - 34.ImportedFromIB2 342.IBPluginDependency 343.IBPluginDependency 344.IBPluginDependency @@ -3111,7 +3237,6 @@ 347.IBPluginDependency 348.IBPluginDependency 35.IBPluginDependency - 35.ImportedFromIB2 350.IBPluginDependency 352.IBPluginDependency 353.IBPluginDependency @@ -3120,7 +3245,6 @@ 356.IBPluginDependency 358.IBPluginDependency 36.IBPluginDependency - 36.ImportedFromIB2 361.IBPluginDependency 362.IBPluginDependency 363.IBPluginDependency @@ -3129,7 +3253,6 @@ 366.IBPluginDependency 37.IBAttributePlaceholdersKey 37.IBPluginDependency - 37.ImportedFromIB2 373.IBPluginDependency 374.IBPluginDependency 375.IBPluginDependency @@ -3139,278 +3262,179 @@ 379.IBPluginDependency 38.IBAttributePlaceholdersKey 38.IBPluginDependency - 38.ImportedFromIB2 380.IBPluginDependency - 381.IBPluginDependency 382.IBAttributePlaceholdersKey 382.IBPluginDependency - 382.ImportedFromIB2 383.IBPluginDependency 384.IBPluginDependency 385.IBPluginDependency 388.IBAttributePlaceholdersKey 388.IBPluginDependency - 388.ImportedFromIB2 389.IBPluginDependency 39.IBAttributePlaceholdersKey 39.IBPluginDependency - 39.ImportedFromIB2 390.IBPluginDependency 391.IBPluginDependency 396.IBAttributePlaceholdersKey 396.IBPluginDependency - 396.ImportedFromIB2 397.IBPluginDependency 398.IBAttributePlaceholdersKey 398.IBPluginDependency - 398.ImportedFromIB2 399.IBPluginDependency 40.IBPluginDependency - 40.ImportedFromIB2 400.IBPluginDependency - 400.ImportedFromIB2 401.IBPluginDependency - 401.ImportedFromIB2 402.IBPluginDependency - 402.ImportedFromIB2 403.IBPluginDependency - 403.ImportedFromIB2 407.IBAttributePlaceholdersKey 407.IBPluginDependency - 407.ImportedFromIB2 408.IBAttributePlaceholdersKey 408.IBPluginDependency - 408.ImportedFromIB2 409.IBPluginDependency 41.IBPluginDependency - 41.ImportedFromIB2 410.IBPluginDependency 42.IBPluginDependency - 42.ImportedFromIB2 420.IBPluginDependency 421.IBAttributePlaceholdersKey 421.IBPluginDependency - 421.ImportedFromIB2 422.IBPluginDependency 423.IBPluginDependency 427.IBAttributePlaceholdersKey 427.IBPluginDependency - 427.ImportedFromIB2 428.IBPluginDependency 429.IBPluginDependency - 429.ImportedFromIB2 43.IBPluginDependency - 43.ImportedFromIB2 430.IBPluginDependency - 430.ImportedFromIB2 431.IBPluginDependency - 431.ImportedFromIB2 432.IBPluginDependency - 432.ImportedFromIB2 438.IBPluginDependency 439.IBPluginDependency 44.IBAttributePlaceholdersKey 44.IBPluginDependency - 44.ImportedFromIB2 440.IBPluginDependency 441.IBPluginDependency 442.IBPluginDependency 443.IBPluginDependency + 450.IBPluginDependency + 451.IBPluginDependency + 453.IBPluginDependency + 454.IBPluginDependency 46.IBAttributePlaceholdersKey 46.IBPluginDependency - 46.ImportedFromIB2 49.IBAttributePlaceholdersKey 49.IBPluginDependency - 49.ImportedFromIB2 - 5.IBEditorWindowLastContentRect 5.IBPluginDependency - 5.ImportedFromIB2 - 5.editorWindowContentRectSynchronizationRect 50.IBAttributePlaceholdersKey 50.IBPluginDependency - 50.ImportedFromIB2 51.IBPluginDependency - 51.ImportedFromIB2 52.IBPluginDependency - 52.ImportedFromIB2 53.IBPluginDependency - 53.ImportedFromIB2 54.IBPluginDependency - 54.ImportedFromIB2 55.IBPluginDependency - 55.ImportedFromIB2 56.IBAttributePlaceholdersKey 56.IBPluginDependency - 56.ImportedFromIB2 57.IBPluginDependency - 57.ImportedFromIB2 58.IBPluginDependency - 58.ImportedFromIB2 59.IBPluginDependency - 59.ImportedFromIB2 6.IBAttributePlaceholdersKey 6.IBPluginDependency - 6.ImportedFromIB2 60.IBPluginDependency - 60.ImportedFromIB2 61.IBAttributePlaceholdersKey 61.IBPluginDependency - 61.ImportedFromIB2 62.IBPluginDependency - 62.ImportedFromIB2 63.IBPluginDependency - 63.ImportedFromIB2 64.IBPluginDependency - 64.ImportedFromIB2 65.IBPluginDependency - 65.ImportedFromIB2 66.IBAttributePlaceholdersKey 66.IBPluginDependency - 66.ImportedFromIB2 7.IBPluginDependency - 7.ImportedFromIB2 73.IBAttributePlaceholdersKey 73.IBPluginDependency - 73.ImportedFromIB2 74.IBAttributePlaceholdersKey 74.IBPluginDependency - 74.ImportedFromIB2 75.IBPluginDependency - 75.ImportedFromIB2 76.IBPluginDependency - 76.ImportedFromIB2 77.IBPluginDependency - 77.ImportedFromIB2 78.IBPluginDependency - 78.ImportedFromIB2 8.IBPluginDependency - 8.ImportedFromIB2 81.IBAttributePlaceholdersKey 81.IBPluginDependency - 81.ImportedFromIB2 82.IBPluginDependency - 82.ImportedFromIB2 83.IBPluginDependency - 83.ImportedFromIB2 84.IBPluginDependency - 84.ImportedFromIB2 85.IBPluginDependency - 85.ImportedFromIB2 86.IBAttributePlaceholdersKey 86.IBPluginDependency - 86.ImportedFromIB2 87.IBAttributePlaceholdersKey 87.IBPluginDependency - 87.ImportedFromIB2 88.IBAttributePlaceholdersKey 88.IBPluginDependency - 88.ImportedFromIB2 89.IBAttributePlaceholdersKey 89.IBPluginDependency - 89.ImportedFromIB2 9.IBPluginDependency - 9.ImportedFromIB2 90.IBAttributePlaceholdersKey 90.IBPluginDependency - 90.ImportedFromIB2 YES com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - - {{113, 443}, {906, 290}} - com.apple.InterfaceBuilder.CocoaPlugin - - {{42, 754}, {700, 290}} com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -3419,7 +3443,6 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -3428,7 +3451,6 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -3438,12 +3460,9 @@ YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -3454,144 +3473,102 @@ YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin @@ -3599,940 +3576,149 @@ YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - - {{-1032, 213}, {906, 290}} com.apple.InterfaceBuilder.CocoaPlugin - - {{692, 501}, {700, 290}} YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + com.apple.InterfaceBuilder.CocoaPlugin - YES - - YES - + YES - - YES - + - 449 + 456 YES - - FirstResponder - NSObject - - IBUserSource - - - HBAdvancedController NSObject - - YES - - YES - X264AdvancedOptionsAnimate: - X264AdvancedOptionsChanged: - X264AdvancedOptionsSet: - X264AdvancedOptionsSetCurrentSettings: - X264AdvancedOptionsStandardizeOptString: - - - YES - id - id - id - id - id - - - - YES - - YES - fDisplayX264Options - fDisplayX264OptionsLabel - fEmptyView - fX264opt8x8dctLabel - fX264opt8x8dctSwitch - fX264optAlphaDeblockPopUp - fX264optAnalyseLabel - fX264optAnalysePopUp - fX264optAqLabel - fX264optAqSlider - fX264optBAdaptLabel - fX264optBAdaptPopUp - fX264optBPyramidLabel - fX264optBPyramidPopUp - fX264optBetaDeblockPopUp - fX264optBframesLabel - fX264optBframesPopUp - fX264optCabacLabel - fX264optCabacSwitch - fX264optDeblockLabel - fX264optDirectPredLabel - fX264optDirectPredPopUp - fX264optMERangeLabel - fX264optMERangePopUp - fX264optMotionEstLabel - fX264optMotionEstPopUp - fX264optNodctdcmtLabel - fX264optNodctdcmtSwitch - fX264optPsyRDLabel - fX264optPsyRDSlider - fX264optPsyTrellisLabel - fX264optPsyTrellisSlider - fX264optRefLabel - fX264optRefPopUp - fX264optSubmeLabel - fX264optSubmePopUp - fX264optTrellisLabel - fX264optTrellisPopUp - fX264optView - fX264optViewTitleLabel - fX264optWeightPLabel - fX264optWeightPSwitch - - - YES - NSTextField - NSTextField - NSView - NSTextField - NSButton - NSPopUpButton - NSTextField - NSPopUpButton - NSTextField - NSSlider - NSTextField - NSPopUpButton - NSTextField - NSPopUpButton - NSPopUpButton - NSTextField - NSPopUpButton - NSTextField - NSButton - NSTextField - NSTextField - NSPopUpButton - NSTextField - NSPopUpButton - NSTextField - NSPopUpButton - NSTextField - NSButton - NSTextField - NSSlider - NSTextField - NSSlider - NSTextField - NSPopUpButton - NSTextField - NSPopUpButton - NSTextField - NSPopUpButton - NSView - NSTextField - NSTextField - NSButton - - IBProjectSource - HBAdvancedController.h - - - - HBAdvancedController - NSObject - - IBUserSource - - - - - NSObject - - IBUserSource - - - - - - YES - - NSActionCell - NSCell - - IBFrameworkSource - AppKit.framework/Headers/NSActionCell.h - - - - NSApplication - NSResponder - - IBFrameworkSource - AppKit.framework/Headers/NSApplication.h - - - - NSApplication - - IBFrameworkSource - AppKit.framework/Headers/NSApplicationScripting.h - - - - NSApplication - - IBFrameworkSource - AppKit.framework/Headers/NSColorPanel.h - - - - NSApplication - - IBFrameworkSource - AppKit.framework/Headers/NSHelpManager.h - - - - NSApplication - - IBFrameworkSource - AppKit.framework/Headers/NSPageLayout.h - - - - NSApplication - - IBFrameworkSource - AppKit.framework/Headers/NSUserInterfaceItemSearching.h - - - - NSButton - NSControl - - IBFrameworkSource - AppKit.framework/Headers/NSButton.h - - - - NSButtonCell - NSActionCell - - IBFrameworkSource - AppKit.framework/Headers/NSButtonCell.h - - - - NSCell - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSCell.h - - - - NSControl - NSView - - IBFrameworkSource - AppKit.framework/Headers/NSControl.h - - - - NSFormatter - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSFormatter.h - - - - NSMenu - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSMenu.h - - - - NSMenuItem - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSMenuItem.h - - - - NSMenuItemCell - NSButtonCell - - IBFrameworkSource - AppKit.framework/Headers/NSMenuItemCell.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSAccessibility.h - - - - NSObject - - - - NSObject - - - - NSObject - - - - NSObject - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSDictionaryController.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSDragging.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSFontManager.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSFontPanel.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSKeyValueBinding.h - - - - NSObject - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSNibLoading.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSOutlineView.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSPasteboard.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSSavePanel.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSTableView.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSToolbarItem.h - - - - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSView.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSArchiver.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSClassDescription.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSError.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSFileManager.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSKeyValueCoding.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSKeyValueObserving.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSKeyedArchiver.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSObject.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSObjectScripting.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSPortCoder.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSRunLoop.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSScriptClassDescription.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSScriptKeyValueCoding.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSScriptObjectSpecifiers.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSScriptWhoseTests.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSThread.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSURL.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSURLConnection.h - - - - NSObject - - IBFrameworkSource - Foundation.framework/Headers/NSURLDownload.h - - - - NSObject - - IBFrameworkSource - Growl.framework/Headers/GrowlApplicationBridge.h - - - - NSObject - - IBFrameworkSource - ImageKit.framework/Headers/IKImageBrowserView.h - - - - NSObject - - IBFrameworkSource - ImageKit.framework/Headers/IKSaveOptions.h - - - - NSObject - - IBFrameworkSource - ImageKit.framework/Headers/ImageKitDeprecated.h - - - - NSObject - - IBFrameworkSource - PDFKit.framework/Headers/PDFDocument.h - - - - NSObject - - IBFrameworkSource - PDFKit.framework/Headers/PDFView.h - - - - NSObject - - IBFrameworkSource - QTKit.framework/Headers/QTCaptureDecompressedAudioOutput.h - - - - NSObject - - IBFrameworkSource - QTKit.framework/Headers/QTCaptureDecompressedVideoOutput.h - - - - NSObject - - IBFrameworkSource - QTKit.framework/Headers/QTCaptureFileOutput.h - - - - NSObject - - IBFrameworkSource - QTKit.framework/Headers/QTCaptureVideoPreviewOutput.h - - - - NSObject - - IBFrameworkSource - QTKit.framework/Headers/QTCaptureView.h - - - - NSObject - - IBFrameworkSource - QTKit.framework/Headers/QTMovie.h - - - - NSObject - - IBFrameworkSource - QTKit.framework/Headers/QTMovieView.h - - - - NSObject - - IBFrameworkSource - QuartzComposer.framework/Headers/QCCompositionParameterView.h - - - - NSObject - - IBFrameworkSource - QuartzComposer.framework/Headers/QCCompositionPickerView.h - - - - NSObject - - IBFrameworkSource - QuartzFilters.framework/Headers/QuartzFilterManager.h - - - - NSObject - - IBFrameworkSource - QuickLookUI.framework/Headers/QLPreviewPanel.h - - - - NSObject - - IBFrameworkSource - Sparkle.framework/Headers/SUAppcast.h - - - - NSObject - - IBFrameworkSource - Sparkle.framework/Headers/SUUpdater.h - - - - NSPopUpButton - NSButton - - IBFrameworkSource - AppKit.framework/Headers/NSPopUpButton.h - - - - NSPopUpButtonCell - NSMenuItemCell - - IBFrameworkSource - AppKit.framework/Headers/NSPopUpButtonCell.h - - - - NSResponder - - IBFrameworkSource - AppKit.framework/Headers/NSInterfaceStyle.h - - - - NSResponder - NSObject - - IBFrameworkSource - AppKit.framework/Headers/NSResponder.h - - - - NSSlider - NSControl - - IBFrameworkSource - AppKit.framework/Headers/NSSlider.h + ./Classes/HBAdvancedController.h - - NSSliderCell - NSActionCell - - IBFrameworkSource - AppKit.framework/Headers/NSSliderCell.h - - - - NSTextField - NSControl - - IBFrameworkSource - AppKit.framework/Headers/NSTextField.h - - - - NSTextFieldCell - NSActionCell - - IBFrameworkSource - AppKit.framework/Headers/NSTextFieldCell.h - - - - NSView - - IBFrameworkSource - AppKit.framework/Headers/NSClipView.h - - - - NSView - - - - NSView - - IBFrameworkSource - AppKit.framework/Headers/NSRulerView.h - - - - NSView - NSResponder - - 0 + IBCocoaFramework com.apple.InterfaceBuilder.CocoaPlugin.macosx @@ -4542,7 +3728,19 @@ YES - ../HandBrake.xcodeproj 3 + + YES + + YES + NSMenuCheckmark + NSMenuMixedState + + + YES + {9, 8} + {7, 2} + + diff --git a/macosx/HBAdvancedController.h b/macosx/HBAdvancedController.h index bc6e5b808..b59746e8f 100644 --- a/macosx/HBAdvancedController.h +++ b/macosx/HBAdvancedController.h @@ -16,6 +16,9 @@ IBOutlet NSTextField * fX264optViewTitleLabel; IBOutlet NSTextField * fDisplayX264OptionsLabel; IBOutlet NSTextField * fDisplayX264Options; + IBOutlet NSTextField * fDisplayLavcOptionsLabel; + IBOutlet NSTextField * fDisplayLavcOptions; + IBOutlet NSTextField * fX264optBframesLabel; IBOutlet NSPopUpButton * fX264optBframesPopUp; IBOutlet NSTextField * fX264optRefLabel; @@ -59,7 +62,9 @@ - (void) setView: (NSBox *) box; - (BOOL) loadMyNibFile; - (NSString *) optionsString; +- (NSString *) optionsStringLavc; - (void) setOptions: (NSString *)string; +- (void) setLavcOptions: (NSString *)string; - (void) enableUI: (bool) b; - (void) setHidden: (BOOL) hide; - (IBAction) X264AdvancedOptionsAnimate: (id) sender; diff --git a/macosx/HBAdvancedController.m b/macosx/HBAdvancedController.m index b8bb553c2..55da0c06b 100644 --- a/macosx/HBAdvancedController.m +++ b/macosx/HBAdvancedController.m @@ -38,23 +38,31 @@ return [fDisplayX264Options stringValue]; } +- (NSString *) optionsStringLavc +{ + return [fDisplayLavcOptions stringValue]; +} + - (void) setOptions: (NSString *)string { [fDisplayX264Options setStringValue:string]; [self X264AdvancedOptionsSet:nil]; } +- (void) setLavcOptions: (NSString *)string +{ + [fDisplayLavcOptions setStringValue:string]; +} + - (void) setHidden: (BOOL) hide { if(hide) { [fOptionsBox setContentView:fEmptyView]; - [fX264optViewTitleLabel setStringValue: @"Only Used With The x264 (H.264) Codec"]; } else { [fOptionsBox setContentView:fX264optView]; - [fX264optViewTitleLabel setStringValue: @""]; } return; } diff --git a/macosx/HBQueueController.mm b/macosx/HBQueueController.mm index 86f1b759b..41576e242 100644 --- a/macosx/HBQueueController.mm +++ b/macosx/HBQueueController.mm @@ -1316,7 +1316,27 @@ return ![(HBQueueOutlineView*)outlineView isDragging]; if ([[item objectForKey:@"VideoEncoder"] isEqualToString: @"H.264 (x264)"]) { [finalString appendString: @"x264 Options: " withAttributes:detailBoldAttr]; - [finalString appendString: [item objectForKey:@"x264Option"] withAttributes:detailAttr]; + if ([item objectForKey:@"x264Option"]) + { + [finalString appendString: [item objectForKey:@"x264Option"] withAttributes:detailAttr]; + } + else + { + [finalString appendString: @"x264 defaults" withAttributes:detailAttr]; + } + [finalString appendString:@"\n" withAttributes:detailAttr]; + } + else // we must be ffmpeg (lavc) + { + [finalString appendString: @"FFmpeg (lavc) Options: " withAttributes:detailBoldAttr]; + if ([item objectForKey:@"lavcOption"]) + { + [finalString appendString: [item objectForKey:@"lavcOption"] withAttributes:detailAttr]; + } + else + { + [finalString appendString: @"FFmpeg (lavc) defaults" withAttributes:detailAttr]; + } [finalString appendString:@"\n" withAttributes:detailAttr]; } -- cgit v1.2.3