From c6fd68fbc5c3e8775b485c8c3e10eb359173ee90 Mon Sep 17 00:00:00 2001 From: Tim Walker Date: Sun, 22 Nov 2015 00:40:38 +0100 Subject: libav: remove a pointless check in the DTS decoder. The check resulted in an error with many real-world streams, which are otherwise perfectly valid. The auxiliary data length is not reliable and/or the ETSI DTS specification is incorrect. --- contrib/ffmpeg/A13-dcadec-false-overread.patch | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 contrib/ffmpeg/A13-dcadec-false-overread.patch (limited to 'contrib/ffmpeg') diff --git a/contrib/ffmpeg/A13-dcadec-false-overread.patch b/contrib/ffmpeg/A13-dcadec-false-overread.patch new file mode 100644 index 000000000..50ca00169 --- /dev/null +++ b/contrib/ffmpeg/A13-dcadec-false-overread.patch @@ -0,0 +1,23 @@ +diff --git a/libavcodec/dcadec.c b/libavcodec/dcadec.c +index e988e94..a72195e 100644 +--- a/libavcodec/dcadec.c ++++ b/libavcodec/dcadec.c +@@ -1359,12 +1359,12 @@ static int dca_subframe_footer(DCAContext *s, int base_channel) + align_get_bits(&s->gb); // byte align + skip_bits(&s->gb, 16); // nAUXCRC16 + +- // additional data (reserved, cf. ETSI TS 102 114 V1.4.1) +- if ((reserved = (aux_data_end - get_bits_count(&s->gb))) < 0) { +- av_log(s->avctx, AV_LOG_ERROR, +- "Overread auxiliary data by %d bits\n", -reserved); +- return AVERROR_INVALIDDATA; +- } else if (reserved) { ++ /* ++ * additional data (reserved, cf. ETSI TS 102 114 V1.4.1) ++ * ++ * Note: don't check for overreads, aux_data_count can't be trusted. ++ */ ++ if ((reserved = (aux_data_end - get_bits_count(&s->gb))) > 0) { + avpriv_request_sample(s->avctx, + "Core auxiliary data reserved content"); + skip_bits_long(&s->gb, reserved); -- cgit v1.2.3