| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Enabling VAAPI for GNU/Linux (SYS_LINUX) only, adding libraries 'X11 va-drm va-x11 va'
and USE_VAAPI define.
- hb.c:
- Adding global static 'vaapi_device_ctx0' default device
initialized via hb_avcodec_init() and released via hb_avcodec_free()
- hb_avcodec_vaapi_set_hwframe_ctx() attaches the new AVHWFramesContext
to the AVCodecContext
- hb_avcodec_test_encoder(..) adds VAAPI branch,
needs refinement
- encavcodec.c
- adding VAAPI branches, enabling available, needs refinement
Discussion:
First of all, only on Intel hardware I was able to produce a correct
encoded result. On AMD we seemingly have YUV420 / NV12 artifacts.
Therefor I need to learn more details on the pix_fmt handling
as described below.
While adding the VAAPI ffmpeg support the following might be an issue.
Usually HB seems to operate with AV_PIX_FMT_YUV420P in general
being set in the AVCodecContext's pix_fmt.
VAAPI performs as follows:
- It uses hardware frames on the target device, which are being transported
from the software device. Both format should be allowed to differ??
- AVCodecContext's pix_fmt uses AV_PIX_FMT_VAAPI
- AVHWFramesContext: format uses AV_PIX_FMT_VAAPI and sw_format AV_PIX_FMT_NV12,
the latter hinting on the actual hw-frame's target format.
- AV_PIX_FMT_NV12 uses interleaved UV data, where AV_PIX_FMT_YUV420P uses
seperated planes. Both use a separated Y plane upfront.
Therefor both formats are not picture compatible, memory requirements are same.
- Encode(..) hardcodes the source frame's to AV_PIX_FMT_YUV420P in VAAPI case,
usually the AVCodecContext's pix_fmt is being used.
I need to identify how HB uses AVCodecContext's pix_fmt, i.e. respects
the desired pix_fmt.
Then a hw_frame gets allocated and the source frame is being transported
to this target. Probably it happens here in VAAPI AMD case, that the YUV420
data is not being transformed to NV12.
Now the hw_frame is being sent 'avcodec_send_frame' and the code-path re-aligns
with non VAAPI.
Further fixes to do:
Naming of VAAPI's profile and level .. figuring out which settings are generally accepted.
Now the bf (b-frames) is set to zero, since it produces a failure otherwise.
The latter should only happen in certain profiles, but .. it does even in 100=high
|
|\ |
|
| | |
|
| |
| |
| |
| | |
Fixes https://github.com/HandBrake/HandBrake/issues/1086
|
|\| |
|
| | |
|
| |
| |
| |
| |
| |
| | |
Adding the specific FFMPEG encoder suffix allows support for more encoders like VAAPI.
Cleaned up overall HB_VCODED_* to 32bit signed integer space within 0x7FFFFFFF.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Fix HB_VCODEC_FFMPEG_MASK covered values to lie within mask
- Fix HB_VCODEC_FFMPEG_H264 usage (gtk version missed a rename)
- Fix FFMPEG hwaccel build is required for Nvenc
Basically working:
- h264_nvenc
- hevc_nvenc
Possible optimization:
- Even in constant quality mode, a user ceiling bit_rate might be desirable,
currently only the maximum is used like in VP8/9: w x h x fps
Remaining issues:
1) Muxer issue with h264_nvenc + MKV, ffprobe shows:
[h264 @ 0x55ae4dedacc0] sps_id 32 out of range
[h264 @ 0x55ae4dedacc0] Invalid nal size 1677734572
[h264 @ 0x55ae4dedacc0] missing picture in access unit with size 40644
Notable: This does not happen with hevc_nvenc
Tested:
- GNU/Linux Debian 9
- GeForce GTX 950
- BD 1080p source, cropped: Around 70fps h264 + hevc
|
|/ |
|
| |
|
| |
|
|
|
|
| |
GTK will use lower res icons if available for lower res screens.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
The angle setting is not part of a preset
|
| |
|
|
|
|
| |
Instead of right justification
|
| |
|
| |
|
|
|
|
| |
Move under Filters
|
| |
|
|
|
|
|
|
| |
Adds "Save As" menu option and "Save New Preset" button.
Preset "Save" menu option behaviour changes to to only allow updating
the current preset.
|
| |
|
|
|
|
|
|
| |
Bold "Title:", "Angle:", "Duration:"
Add "Range:"
Change "through" to "-"
|
| |
|
| |
|
|
|
|
|
|
|
| |
Replace with a preference option that synchronizes all title settings by
default. This makes the linux gui behaviour consistant with the other
guis by default. Titles can have independent settings by unchecking the
preference option.
|
|
|
|
| |
Fixes #1040.
|
|
|
|
| |
Fixes https://github.com/HandBrake/HandBrake/issues/995
|
| |
|
| |
|
| |
|
|
|
|
| |
Lost the text during one of the UI shuffles
|
|
|
|
| |
Make drag-n-drop respect the single folder level heirchary
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces the "New Folder" option in the presets menu. It enforces
the folder structure we have agreed to and hopefully helps the user keep
things organized.
Note that users are allowed to save a custom preset to the same
"Category" as an official preset. When they do this, a new custom
category is created with the same name and the preset is saved in that
folder.
|
|
|
|
| |
Other source types can also have multiples angles
|
|
|
|
| |
and remove some cruft.
|
| |
|
| |
|
|
|
|
|
|
| |
Previously, you could only delete the currently highlighted item. Now
you can delete the current item in the presets menu button, even if
settings have been modified and the list item is not highlighted.
|
|
|
|
|
| |
When a setting is modified, the word "Modified" appears next to the
preset selection menu button and the "Reset" button is enabled.
|
| |
|
| |
|
|
|
|
|
|
|
| |
And convert appliction to a GtkApplication. This allows the use of
GActions for menu and other control actions. It's a cleaner simpler
interface that automatically tracks when multiple widgets perform the
same action and keeps their state in sync.
|
| |
|