summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--macosx/HBDistributedArray.h11
-rw-r--r--macosx/HBDistributedArray.m28
2 files changed, 32 insertions, 7 deletions
diff --git a/macosx/HBDistributedArray.h b/macosx/HBDistributedArray.h
index e72484aae..483f1ac57 100644
--- a/macosx/HBDistributedArray.h
+++ b/macosx/HBDistributedArray.h
@@ -18,6 +18,11 @@ extern NSString *HBDistributedArrayChanged;
@end
+typedef NS_ENUM(NSUInteger, HBDistributedArrayContent) {
+ HBDistributedArrayContentAcquired,
+ HBDistributedArrayContentReload,
+};
+
/**
* HBDistributedArray
* a mutable array that share its content between processes.
@@ -33,9 +38,11 @@ extern NSString *HBDistributedArrayChanged;
- (instancetype)initWithURL:(NSURL *)fileURL;
/**
- * Begin a transaction on the array
+ * Begins a transaction on the array
+ *
+ * @return whether the array content changes or not after beginning the transaction.
*/
-- (void)beginTransaction;
+- (HBDistributedArrayContent)beginTransaction;
/**
* Commit the changes and notify
diff --git a/macosx/HBDistributedArray.m b/macosx/HBDistributedArray.m
index 704f828c4..867ee4ffb 100644
--- a/macosx/HBDistributedArray.m
+++ b/macosx/HBDistributedArray.m
@@ -59,6 +59,7 @@ NSString *HBDistributedArraWrittenToDisk = @"HBDistributedArraWrittenToDisk";
@property (nonatomic, readwrite) NSTimeInterval modifiedTime;
@property (nonatomic, readonly) sem_t *mutex;
+@property (nonatomic, readwrite) uint32_t mutexCount;
@end
@@ -87,7 +88,8 @@ NSString *HBDistributedArraWrittenToDisk = @"HBDistributedArraWrittenToDisk";
// it can cause a deadlock if an instance
// crashed while it has the lock on the semaphore.
_mutex = sem_open(name, O_CREAT, 0777, 1);
- if (_mutex == SEM_FAILED) {
+ if (_mutex == SEM_FAILED)
+ {
NSLog(@"%s: %d\n", "Error in creating semaphore: ", errno);
}
@@ -118,15 +120,25 @@ NSString *HBDistributedArraWrittenToDisk = @"HBDistributedArraWrittenToDisk";
- (void)lock
{
- sem_wait(self.mutex);
+ if (self.mutexCount == 0)
+ {
+ sem_wait(self.mutex);
+ }
+
+ self.mutexCount++;
}
- (void)unlock
{
- sem_post(self.mutex);
+ if (self.mutexCount == 1)
+ {
+ sem_post(self.mutex);
+ }
+
+ self.mutexCount--;
}
-- (void)beginTransaction
+- (HBDistributedArrayContent)beginTransaction
{
[self lock];
// We got the lock, need to check if
@@ -135,16 +147,22 @@ NSString *HBDistributedArraWrittenToDisk = @"HBDistributedArraWrittenToDisk";
// could have not received the notification yet
NSDate *date = nil;
[self.fileURL getResourceValue:&date forKey:NSURLAttributeModificationDateKey error:nil];
- if (date.timeIntervalSinceReferenceDate > self.modifiedTime)
+ if (date.timeIntervalSinceReferenceDate > ceil(self.modifiedTime))
{
// File was modified while we waited on the lock
// reload it
[self reload];
+ NSLog(@"WTF");
+ return HBDistributedArrayContentReload;
}
+
+ return HBDistributedArrayContentAcquired;
}
- (void)commit
{
+ // Save changes to disk
+ // and unlock
[self synchronize];
[self unlock];
}