diff options
author | jstebbins <[email protected]> | 2011-10-15 00:16:02 +0000 |
---|---|---|
committer | jstebbins <[email protected]> | 2011-10-15 00:16:02 +0000 |
commit | c1b07b544a635df3f03da077d284219381c60477 (patch) | |
tree | f0380dcf3bfb5c082c5db2ac282489f25467482c /win/CS/Controls | |
parent | fef8e0b3d51ce29f2cb4e99ee6d9aef31d2e6d95 (diff) |
fix crash during 2 pass encoding TS or PS source
stream.c cached information that it probed during the first time it
opened any source. Then later it would re-use that cached data. I
was prematurely deleting the cached data during 2 pass encodes.
The problem is that there is no way to know when the cached data is no
longer needed. You could have a thousand items in the queue all using
the same source, or you could have only 1. So you either have to (a)
keep the cached data indefinitely, or (b) you have to be able to handle
the case where scanned cached data is flushed before you start an
encode. (a) is poor design. And if you choose (b) you might as well
eliminate the cache all together. It doesn't really save any time and
only complicates the code.
In summary, the cache is gone.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@4286 b64f7644-9d1e-0410-96f1-a4d463321fa5
Diffstat (limited to 'win/CS/Controls')
0 files changed, 0 insertions, 0 deletions