diff options
| author | jstebbins <[email protected]> | 2012-05-05 18:22:37 +0000 |
|---|---|---|
| committer | jstebbins <[email protected]> | 2012-05-05 18:22:37 +0000 |
| commit | 06254850dc2c1ec43d57f4d8e2026fa67967d5b9 (patch) | |
| tree | c7ff6a64e1310d79f4f17b1a6bfe9aebaf88a958 /test/test.c | |
| parent | 1c8309d77ea303954f8c9e3919c595de54f173f2 (diff) | |
libhb: Fix problem with positions of burned-in subs
When cropping and/or scaling, the position of burned-in SSA subs was broken.
Also, when scaling, the position of all other burned-in subs was broken.
Part of this fix is to revert a bit of filter initialization changes that
were made in this commit https://trac.handbrake.fr/changeset/4605
The other part of the fix is to add cropping parameters to the initialization
of the subtitle rendering filter. This filter needs the *original* title
dimensions and the crop values in order to compute the positions properly.
The changes that I am reverting gave it the scaled job dimensions and the
crop values. This was wrong in so many ways it's embarassing :p
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@4642 b64f7644-9d1e-0410-96f1-a4d463321fa5
Diffstat (limited to 'test/test.c')
| -rw-r--r-- | test/test.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/test/test.c b/test/test.c index 27c7d498b..36a0eb248 100644 --- a/test/test.c +++ b/test/test.c @@ -2243,8 +2243,12 @@ static int HandleEvents( hb_handle_t * h ) if ( sub_burned ) { + char * filter_str; + filter_str = hb_strdup_printf("%d:%d:%d:%d", + job->crop[0], job->crop[1], job->crop[2], job->crop[3] ); filter = hb_filter_init( HB_FILTER_RENDER_SUB ); - hb_add_filter( job, filter, NULL); + hb_add_filter( job, filter, filter_str); + free( filter_str ); } if( srtfile ) |