summaryrefslogtreecommitdiffstats
path: root/libhb/muxavformat.c
diff options
context:
space:
mode:
authorjstebbins <[email protected]>2015-02-04 18:05:26 +0000
committerjstebbins <[email protected]>2015-02-04 18:05:26 +0000
commit65e34d3a3982d782b71b4b6775b2a38e623efa15 (patch)
treea538c15f9c9b13e4c4cb4e1d777d5849aa883bda /libhb/muxavformat.c
parent9d3c88759e0fc44e6dcd5cfd9e5baf8033468ac2 (diff)
mux: fix chapter timestamps, factor in video encoder delay
libav does not fix chapter timestamps for us, so we must do this until I can figure out a good fix to libav. git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6871 b64f7644-9d1e-0410-96f1-a4d463321fa5
Diffstat (limited to 'libhb/muxavformat.c')
-rw-r--r--libhb/muxavformat.c23
1 files changed, 22 insertions, 1 deletions
diff --git a/libhb/muxavformat.c b/libhb/muxavformat.c
index 266a3ae45..643c1d0dd 100644
--- a/libhb/muxavformat.c
+++ b/libhb/muxavformat.c
@@ -47,6 +47,8 @@ struct hb_mux_object_s
int ntracks;
hb_mux_data_t ** tracks;
+
+ int64_t chapter_delay;
};
enum
@@ -194,6 +196,7 @@ static int avformatInit( hb_mux_object_t * m )
job->mux_data = track;
track->type = MUX_TYPE_VIDEO;
+ track->prev_chapter_tc = AV_NOPTS_VALUE;
track->st = avformat_new_stream(m->oc, NULL);
if (track->st == NULL)
{
@@ -959,7 +962,11 @@ static int add_chapter(hb_mux_object_t *m, int64_t start, int64_t end, char * ti
chap->id = nchap;
chap->time_base = m->time_base;
- chap->start = start;
+ // libav does not currently have a good way to deal with chapters and
+ // delayed stream timestamps. It makes no corrections to the chapter
+ // track. A patch to libav would touch a lot of things, so for now,
+ // work around the issue here.
+ chap->start = start + m->chapter_delay;
chap->end = end;
av_dict_set(&chap->metadata, "title", title, 0);
@@ -973,6 +980,20 @@ static int avformatMux(hb_mux_object_t *m, hb_mux_data_t *track, hb_buffer_t *bu
hb_job_t *job = m->job;
uint8_t sub_out[2048];
+ if (track->type == MUX_TYPE_VIDEO &&
+ track->prev_chapter_tc == AV_NOPTS_VALUE)
+ {
+ // Chapter timestamps are biased the same as video timestamps.
+ // This needs to be reflected in the initial chapter timestamp.
+ //
+ // TODO: Don't assume the first chapter is at 0. Pass the first
+ // chapter through the pipeline instead of dropping it as we
+ // currently do.
+ m->chapter_delay = av_rescale_q(m->job->config.h264.init_delay,
+ (AVRational){1,90000},
+ track->st->time_base);
+ track->prev_chapter_tc = -m->chapter_delay;
+ }
// We only compute dts duration for MP4 files
if (track->type == MUX_TYPE_VIDEO && (job->mux & HB_MUX_MASK_MP4))
{