diff options
author | jstebbins <[email protected]> | 2011-04-16 01:11:53 +0000 |
---|---|---|
committer | jstebbins <[email protected]> | 2011-04-16 01:11:53 +0000 |
commit | f7cf2757ca1839b131d153e1a50029c2ed10f8b1 (patch) | |
tree | 54bfc657e745b3e3ffa907288aee469fd3f0be42 /libhb/hb.c | |
parent | 61460ce74a948d7ba36240fbc9fb658168c2f834 (diff) |
Fix int overflow that can happen when computing PAR
If the source has large non-reduced PAR values, our computed value
was overflowing an int. Compute it in an int64_t then reduce it.
Also, keep num and den below 65535. Larger values just aren't really
significant and will cause more overflow issues.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@3931 b64f7644-9d1e-0410-96f1-a4d463321fa5
Diffstat (limited to 'libhb/hb.c')
-rw-r--r-- | libhb/hb.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/libhb/hb.c b/libhb/hb.c index 55d5f6886..8588f7ff4 100644 --- a/libhb/hb.c +++ b/libhb/hb.c @@ -1025,8 +1025,12 @@ void hb_set_anamorphic_size( hb_job_t * job, /* The film AR is the source's display width / cropped source height. The output display width is the output height * film AR. The output PAR is the output display width / output storage width. */ - pixel_aspect_width = height * cropped_width * pixel_aspect_width; - pixel_aspect_height = width * cropped_height * pixel_aspect_height; + int64_t par_w, par_h; + par_w = (int64_t)height * cropped_width * pixel_aspect_width; + par_h = (int64_t)width * cropped_height * pixel_aspect_height; + hb_limit_rational64( &par_w, &par_h, par_w, par_h, 65535); + pixel_aspect_width = par_w; + pixel_aspect_height = par_h; /* Pass the results back to the caller */ *output_width = width; |