diff options
author | dynaflash <[email protected]> | 2009-06-24 14:59:47 +0000 |
---|---|---|
committer | dynaflash <[email protected]> | 2009-06-24 14:59:47 +0000 |
commit | 949eb02782446c8560647b0f268f81c99deece81 (patch) | |
tree | e901e574dd1c2b6ce4a63f6bfd5dc8c72573e9b3 | |
parent | 08f5cb3e7acabec78d6fabd599a94163a9737217 (diff) |
MacGui: Fix the quality slider setting when using presets for ffmpeg and theora.
- Fix issue where ffmpeg's presets were 2.0 low on the slider.
- Fix theora presets to recognize that the slider is not "inverted" (qp value go higher as quality increases).
-Tested all tree encoders to verify that value saved in preset is reset in gui and reported correctly by libhb.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@2614 b64f7644-9d1e-0410-96f1-a4d463321fa5
-rw-r--r-- | macosx/Controller.mm | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/macosx/Controller.mm b/macosx/Controller.mm index 63523dc1c..faeb0ccb2 100644 --- a/macosx/Controller.mm +++ b/macosx/Controller.mm @@ -6121,7 +6121,16 @@ return YES; } else { - [fVidQualitySlider setFloatValue:([fVidQualitySlider maxValue] - [fVidQualitySlider minValue]) - [[chosenPreset objectForKey:@"VideoQualitySlider"] floatValue]]; + /* Since theora's qp value goes up from left to right, we can just set the slider float value */ + if ([[fVidEncoderPopUp selectedItem] tag] == HB_VCODEC_THEORA) + { + [fVidQualitySlider setFloatValue:[[chosenPreset objectForKey:@"VideoQualitySlider"] floatValue]]; + } + else + { + /* since ffmpeg and x264 use an "inverted" slider (lower qp/rf values indicate a higher quality) we invert the value on the slider */ + [fVidQualitySlider setFloatValue:([fVidQualitySlider maxValue] + [fVidQualitySlider minValue]) - [[chosenPreset objectForKey:@"VideoQualitySlider"] floatValue]]; + } } [self videoMatrixChanged:nil]; |