diff options
| author | sr55 <[email protected]> | 2007-07-17 13:26:22 +0000 |
|---|---|---|
| committer | sr55 <[email protected]> | 2007-07-17 13:26:22 +0000 |
| commit | 33a0ca10fcbb7ad857f7aa58a80b492ac3637da5 (patch) | |
| tree | a8beed52efe86fe59aaf75f8af25dfa62d02a187 | |
| parent | 279364eaf2fb2cbb53f5c1f76dca5c498592857f (diff) | |
WinGui:
- Comments regarding bugs in the Parser. These will need fixed.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@705 b64f7644-9d1e-0410-96f1-a4d463321fa5
| -rw-r--r-- | win/C#/Parsing/AudioTrack.cs | 6 | ||||
| -rw-r--r-- | win/C#/Parsing/Title.cs | 22 |
2 files changed, 28 insertions, 0 deletions
diff --git a/win/C#/Parsing/AudioTrack.cs b/win/C#/Parsing/AudioTrack.cs index 268007c3b..97394971b 100644 --- a/win/C#/Parsing/AudioTrack.cs +++ b/win/C#/Parsing/AudioTrack.cs @@ -76,6 +76,12 @@ namespace Handbrake.Parsing thisTrack.m_trackNumber = int.Parse(splitter[0]);
thisTrack.m_language = splitter[1];
thisTrack.m_format = splitter[2];
+ /*
+ * Problem 2
+ * Field 'Handbrake.frmMain.hbProc' is never assigned to, and will always have it's default value null.
+ * This happens with "AllAudios.iso" which is a test file. http://www.sr88.co.uk/AllAudios.iso (~95MB)
+ */
+
thisTrack.m_subFormat = splitter[3];
thisTrack.m_frequency = int.Parse(splitter[4]);
thisTrack.m_bitrate = int.Parse(splitter[5]);
diff --git a/win/C#/Parsing/Title.cs b/win/C#/Parsing/Title.cs index e55bd78e6..13795c474 100644 --- a/win/C#/Parsing/Title.cs +++ b/win/C#/Parsing/Title.cs @@ -124,6 +124,28 @@ namespace Handbrake.Parsing curLine = output.ReadLine();
splitter = curLine.Split(new string[] { " + autocrop: ", "/" }, StringSplitOptions.RemoveEmptyEntries);
thisTitle.m_autoCrop = new int[4] { int.Parse(splitter[0]), int.Parse(splitter[1]), int.Parse(splitter[2]), int.Parse(splitter[3]) };
+
+ /*
+ *
+ * A Few Bugs that need fixed.
+ *
+ *
+ * Problem 1
+ * There is a small problem here... What happens if the DVD has no Subtitles? or Handbrake misses the Audio or Chapter track
+ * data due to an error.
+ *
+ * hbcli will sit in a suspended state until it is forcefully closed.
+ *
+ * Problem 2
+ * See AudioTrack.cs Line 80 for details
+ *
+ * Problem 3
+ * Doesn't seem to support DVD's where the first track is 0 instead of 1, and only includes 1 title (TS/MPG files)
+ * Simply Doesn't list any titles.
+ *
+ *
+ */
+
thisTitle.m_chapters.AddRange(Chapter.ParseList(output));
thisTitle.m_audioTracks.AddRange(AudioTrack.ParseList(output));
thisTitle.m_subtitles.AddRange(Subtitle.ParseList(output));
|